Fix Stop() not stopping the cron scheduler - #86
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
Start built the job scheduler into a local variable and started it, but never assigned it to the node so Stop() had nothing to call. Every cron job kept running after Stop, including health checks, sync status, node version and peer polling. Now the scheduler is assigned before it starts so Stop can actually stop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start built the job scheduler into a local variable and started it, but never assigned it to the node. Stop only ever calls n.crons.Stop(), so that check was always a no-op. Every cron job kept running after Stop, including health checks, sync status, node version and peer polling, and the scheduler goroutine itself leaked.
Fix assigns the scheduler to the node before starting it so Stop can actually stop it.
Test plan